revert(serve): restore serve_command.py to main state#124
Closed
bedus-creation wants to merge 1 commit into
Closed
revert(serve): restore serve_command.py to main state#124bedus-creation wants to merge 1 commit into
bedus-creation wants to merge 1 commit into
Conversation
Removes the `resolve_host_port()` method and `Uri` dependency that were added in PR #122. Restores the simpler, direct config-resolution approach that lives on origin/main (CLI flag > fastapi config > built-in default). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serve_command.pyback to the cleanorigin/mainstateresolve_host_port()method andUriimport added in commitsf9f533c5and51d4d92e_DEFAULT_HOST/_DEFAULT_PORTmodule-level constants are also removedWhy
PR #122 (
fastapi-serve-command→main) introduced significant complexity toserve_command.pyvia a layeredUri-based host/port resolution chain. Task #196 requests this file be reverted to the state onmainbefore any merging happens.Test plan
git show origin/main:fastapi_startkit/src/fastapi_startkit/fastapi/commands/serve_command.pyexactlyUri/fastapi_startkit.supportimports remain in the serve commandfastapi-serve-commandcontinue to pass🤖 Generated with Claude Code